Skip to content

feat: add session token data source #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 18, 2023
Merged

feat: add session token data source #120

merged 3 commits into from
May 18, 2023

Conversation

sreya
Copy link
Collaborator

@sreya sreya commented May 10, 2023 •
edited
Loading

fixes the TF side of coder/coder#6354

@sreya sreya requested a review from mtojek May 16, 2023 04:12
mtojek
mtojek approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a similar change to this, and I think that this is correct.

You can also drop full .tf file to examples to present the usage. There is examples_test.go which you can use to validate it.

@kylecarbs kylecarbs merged commit dbc530b into main May 18, 2023
@kylecarbs kylecarbs deleted the jon/sessiontoken branch May 18, 2023 04:30
@github-actions github-actions bot locked and limited conversation to collaborators May 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mtojek mtojek mtojek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sreya @mtojek @kylecarbs