Skip to content

fix: coder_parameter: validation min and max are truly optional #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 29, 2023

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented May 26, 2023

Related: coder/coder#7582

This PR fixes parameter decoding logic to enable nil pointers for validation.min and validation.max. Otherwise, fields default to 0.

@mtojek mtojek self-assigned this May 26, 2023
@mtojek mtojek changed the title fix: coder_parameter validation min and max are truly optional fix: coder_parameter: validation min and max are truly optional May 26, 2023
@mtojek mtojek requested a review from mafredri May 29, 2023 11:01
@mtojek mtojek marked this pull request as ready for review May 29, 2023 11:01
@mtojek mtojek requested a review from spikecurtis May 29, 2023 11:07
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏻

@mtojek mtojek merged commit 946db5a into coder:main May 29, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants