fix: terraform-plugin-sdk zeros *int fields #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtojek
commented
May 30, 2023
provider/parameter_test.go
Outdated
| _, foundDisplayName := state.Primary.Attributes["display_name"] | ||
| require.False(t, foundDisplayName, "display_name = "+state.Primary.Attributes["display_name"]) | ||
| _, foundValidationMin := state.Primary.Attributes["validation.0.min"] | ||
| require.False(t, foundValidationMin, "validation.0.min = "+state.Primary.Attributes["validation.0.min"]) |
There was a problem hiding this comment.
@kylecarbs Maybe you have a clue what is the reason.
79a241d to
5f4b94b
Compare
spikecurtis
reviewed
May 31, 2023
mafredri
approved these changes
May 31, 2023
|
Thanks, @mafredri, for taking a look! I will wait for the final approval from @spikecurtis and merge it 👍 |
spikecurtis
approved these changes
Jun 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: coder/coder#7582 (comment)
Changes:
min_okandmax_oktoValidation. These fields substitute the impaired logic in terraform-plugin-sdk (can't handle *ptr).*intwithint(revert last change) as pointers don't give any benefits now.For some reason, the Terraform state containsvalidation.0.min = 0. I managed to fix parameterDataSource to handle nils.If you look at the state, it doesn't contain absent root properties ofcoder_parameter(likedisplay_name), but it contains all forValidation. Why :) ?