feat: Prompt user for parameter values #137
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: coder/coder#6828
Blocked: coder/coder#6828 (comment) We discuss a bit different approach, where the user is not prompted but is able to set the transient parameter value via Parameters. This discussion must be sorted out before proceeding with this PR.
This PR adds a new property to the coder parameter to prompt the user for parameter values.
In the original RFC, we assumed only the
alwaysmode. It means that before the user starts the workspace, a prompt will show up with input fields to enter values. These parameter values will be included only in the current build (I will defer the auto-start behavior for later).