feat: ephemeral parameters must be optional #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
approved these changes
Jul 18, 2023
| @@ -134,6 +134,10 @@ func parameterDataSource() *schema.Resource { | |||
| return diag.Errorf("parameter can't be immutable and ephemeral") | |||
| } | |||
|
|
|||
| if !parameter.Optional && parameter.Ephemeral { | |||
| return diag.Errorf("ephemeral parameter requires the default property") | |||
There was a problem hiding this comment.
Sanity check: do parameters have an optional field or is it inferred by setting default, and is that the only way to do it? (I always stop to ask when I see the check and message say something different.)
There was a problem hiding this comment.
do parameters have an optional field
No.
is it inferred by setting default
Yes 👍
is that the only way to do it
Yes 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: coder/coder#6828
This PR introduces another constraint for ephemeral parameters:
defaultproperty defined.