Skip to content

chore: clarify the format of url for coder_app resource #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 19, 2023
Merged

Conversation

matifali
Copy link
Member

A user has suggested to clarify the format of url in coder_app resource.

See : coder/coder#8574 (comment) for related discussion.

A user has suggested to clarify the format of `url` in `coder_app` resource.

See : coder/coder#8574 (comment) for related discussion.
@matifali matifali requested review from ammario and bpmct July 19, 2023 11:45
@bpmct bpmct merged commit 188ffef into main Jul 19, 2023
@bpmct bpmct deleted the coder_app_docs branch July 19, 2023 12:52
@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2023
@mtojek
Copy link
Member

mtojek commented Aug 10, 2023

@matifali didn't bot complain about the typo in the PR title?

EDIT:

oh, most likely it is enabled only for coder/coder.

@matifali
Copy link
Member Author

Yes most probably. We should add cdr-bot here too.
cc: @ammario

@ammario
Copy link
Member

ammario commented Aug 10, 2023

Taking a break from developing cdr-bot unless something urgent comes up.

@matifali matifali changed the title chore: calrify the format of url for coder_app resource chore: clarify the format of url for coder_app resource Aug 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants