Skip to content

fix: relative_path example #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 1, 2022
Merged

fix: relative_path example #25

merged 2 commits into from
Aug 1, 2022

Conversation

ericpaulsen
Copy link
Member

No description provided.

@ericpaulsen ericpaulsen added the docs Improvements or additions to documentation label Jun 15, 2022
@ericpaulsen ericpaulsen requested a review from bpmct June 15, 2022 14:03
@ericpaulsen ericpaulsen self-assigned this Jun 15, 2022
@ericpaulsen
Copy link
Member Author

@bpmct i see you fixed this in #22, yet it's not reflected on the site...

Comment on lines 30 to 33
name = "VS Code"
icon = data.coder_workspace.me.access_url + "/icons/vscode.svg"
url = "http://localhost:13337"
path = true
relative_path = true
Copy link
Member

@bpmct bpmct Jun 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericpaulsen can you adjust the formatting to align the = signs? terraform fmt should achieve this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

terraform fmt only applies to .tf files, so I manually updated the formatting.

@ericpaulsen
Copy link
Member Author

ericpaulsen commented Jun 16, 2022

@bpmct - also, could I get approved to merge PRs in this repo? i expect i'll be contributing to this repo as we grow the provider. thanks.

@bpmct
Copy link
Member

bpmct commented Jun 16, 2022

I'm afraid I can't help with that cc @kylecarbs

@kylecarbs
Copy link
Member

@ericpaulsen done

@dwahler dwahler merged commit 5fbb03a into main Aug 1, 2022
@dwahler dwahler deleted the relative-path branch August 1, 2022 20:11
DanielleMaywood pushed a commit that referenced this pull request Sep 5, 2024
* fix: relative_path example

* fix: formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants