-
Notifications
You must be signed in to change notification settings - Fork 23
feat: add tooltip field to workspace app #435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I wonder if the markdown link in the tooltip is clickable. What happens when you move from the button to the tooltip? Does it disappear? |
@matifali Updated the PR description with a short video showing what clicking a link in the tooltip looks like. Hopefully that helps! |
@rafrdz This is great. Thank you. |
@rafrdz, one last thing to consider here is if someone used the latest provider with an older version of Coder, where this is not supported? Can we add a warning (or better, fail) in the provider to inform the user of the minimum required Coder version? This warning/error should only happen if someone tries to use If this looks like too much work, I am fine extracting that into a separate PR. |
@matifali Took a look and discussed this with others. Sounds like it'll be a bit of work so going to create an issue for this. |
Summary
In this pull request we're adding an optional
tooltip
field. Thetooltip
field is a string field (with markdown support) that will be used to display tooltips on hover over app buttons in a workspace dashboard.Tooltip screenshot
Tooltip video
tooltip-link.mov
Issue: coder/coder#18431
Related coder PR: coder/coder#19651
Changes
tooltip
to theapp
schema with a max length of 2048 charactersapp
documentation to include thetooltip
fieldtooltip
Testing