feat: Add motd_file to coder_agent #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows us to enable better feature parity with OpenSSH by being able to display a message when users login. This is useful for template authors who want to inform their users about changes or reporting about the state of the workspace.
kylecarbs
approved these changes
Nov 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows us to enable better feature parity with OpenSSH by
being able to display a message when users login. This is useful for
template authors who want to inform their users about changes or
reporting about the state of the workspace.
I did consider if we should turn this into a script, like:
But while this is flexible, it raises questions like how often should we run it, sould we run it on every query, what if it takes a long time to execute, etc. For this reason we're sticking with the simplicity of a single file and making it the responsibility of the author to start a service to update its content, where required.
This feature could be expanded to support things like VSCode/JetBrains extensions as well, to surface the message not just via SSH, but these clients as well.