Skip to content

feat: Improve validation messages for coder_parameter #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 23, 2023
Merged

feat: Improve validation messages for coder_parameter #85

merged 3 commits into from
Jan 23, 2023

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Jan 23, 2023 •
edited
Loading

Related: coder/coder#5574

Changes:

  • format coder_parameter example
  • remove wrong property display_name (does not exist)
  • improve messages to be human friendly: is not a number vs. parse value ddd as int: strconv.Atoi: parsing "ddd": invalid syntax

@mtojek mtojek self-assigned this Jan 23, 2023
@mtojek mtojek requested a review from kylecarbs January 23, 2023 17:06
@mtojek mtojek marked this pull request as ready for review January 23, 2023 17:06
@mtojek
Copy link
Member Author

mtojek commented Jan 23, 2023 •
edited
Loading

Thanks for the review, @kylecarbs!

You’re not authorized to merge this pull request.

Could you please/release-tag this change too?

@kylecarbs
Copy link
Member

@mtojek I'll make you a maintainer!

@mtojek mtojek merged commit e10b5f4 into coder:main Jan 23, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees

@mtojek mtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtojek @kylecarbs