Skip to content

feat: use validation error while parsing coder_parameter #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 23, 2023
Merged

feat: use validation error while parsing coder_parameter #86

merged 2 commits into from
Jan 23, 2023

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Jan 23, 2023 •
edited
Loading

Related: coder/coder#5574

Changes:

  • fix: typo in coder_app example
  • fix: invalid parameter definition in coder_parameter example
  • feat: show Validation.Error when regexp doesn't match
  • feat: test coder_parameter example

@mtojek mtojek self-assigned this Jan 23, 2023
@mtojek mtojek requested review from kylecarbs January 23, 2023 18:58
@mtojek mtojek marked this pull request as ready for review January 23, 2023 18:58
kylecarbs
kylecarbs approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing the example is cool!

@mtojek mtojek merged commit bf04eea into coder:main Jan 23, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kylecarbs kylecarbs Awaiting requested review from kylecarbs

Assignees

@mtojek mtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtojek @kylecarbs