Skip to content

Support setting max port sharing level in template resource #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stirby opened this issue Sep 27, 2024 · 3 comments
Closed

Support setting max port sharing level in template resource #108

stirby opened this issue Sep 27, 2024 · 3 comments
Assignees
@ethanndickson

Comments

@stirby
Copy link

stirby commented Sep 27, 2024

We should allow users to configure the maximum port sharing level in the template resource, as we do in the settings UI.

https://coder.com/docs/networking/port-forwarding#configure-maximum-port-sharing-level-enterprise
@stirby
Copy link
Author

stirby commented Sep 27, 2024

cc @ethanndickson

@ethanndickson
Copy link
Member

ethanndickson commented Sep 30, 2024 •
edited
Loading

The setting was previously missing from the Create request, which I added here: coder/coder#14366. If customers are actually looking to set this via the provider, I can add it in a backwards compatible way (i.e. that doesn't require >=2.15.0) by sending a second PATCH request during resource creation if the attribute is configured.

@ethanndickson ethanndickson mentioned this issue Sep 30, 2024
Merged
@ethanndickson ethanndickson self-assigned this Sep 30, 2024
@ethanndickson
Copy link
Member

Closed by #110.

@matifali matifali added bug and removed enhancement labels Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ethanndickson ethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@matifali @ethanndickson @stirby