fix: skip validating unknown version names #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ethanndickson and the rest of your teammates on |
352de2d to
a533bc8
Compare
ethanndickson
commented
Oct 31, 2024
| if version.Name.IsNull() { | ||
| continue | ||
| } | ||
| if _, ok := uniqueNames[version.Name.ValueString()]; ok { |
There was a problem hiding this comment.
If two names were populated using Terraform variables, they'd be Unknown and ValueString would return the empty string for both, which would then lead to a false duplicate in the map.
johnstcn
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same problem as seen in #115.
This fixes a problem where having multiple template version names manually set using Terraform variables would always return a duplicate name error, as Terraform would mark the attribute, although it is required and already written in the config, as Unknown before calling our custom validator. This unknown value is only ever passed to the validator, never
CreateorUpdate.Knowing this, we see the same problem exists for all attributes we read in our custom validator. The only remaining one is
active, where we check at least one version is marked as active. In this case, we also need to skip validatingactiveif any of the booleans are unknown.We previously didn't have any tests that explicitly used Terraform variables, so this PR adds one, in case the behaviour of these variable set attributes is changed in the future.