chore: allow pushing only inactive coderd_template versions
#167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderd_template versionscoderd_template versions
f91d9db to
afe3400
Compare
ethanndickson
commented
Jan 21, 2025
| } | ||
| if versionDeactivated(prevs, &planVersions[i]) { | ||
| diag.AddError("Client Error", "Plan could not determine which version should be active.\n"+ | ||
| "Either specify an active version or modify the contents of the previously active version before marking it as inactive.") |
There was a problem hiding this comment.
Instead of returning an error and failing the plan here, we could just push a new, identical, template version and not promote it to active. Given there's no other way to push an unmodified template version, and the whole point of this resource is to avoid pushing spurious diffs, I think it's better to just fail the plan.
deansheather
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per some customer feedback, this PR relaxes some of the constraints when creating template versions via the
coderd_templateresource. Previously, each update of the resource required that at least one of the versions in theversionslist had theactiveattribute set to true.This constraint is now only required when:
Examples of these cases can be seen in the tests.
With this, a workflow that involves:
is now possible with just a single item in the list.