Skip to content

feat: add org_sync_idp_groups attribute to coderd_organization resource #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 21, 2025

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Feb 20, 2025

Closes #150

resource "coderd_organization" "bloob" {
  name         = "bloob"
  sync_mapping = ["wibble", "wobble"]
}

Copy link
Member

@ethanndickson ethanndickson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aslilac aslilac changed the title feat: add sync_mapping attribute to coderd_organization resource feat: add org_sync_idp_groups attribute to coderd_organization resource Feb 21, 2025
@aslilac aslilac merged commit ed8270c into main Feb 21, 2025
13 checks passed
@aslilac aslilac deleted the lilac/org-sync-mapping branch February 21, 2025 21:12
ethanndickson added a commit that referenced this pull request Feb 24, 2025
I picked up on this reviewing #182, but it's a mistake I made when
reviewing the resource originally 😓

There's a minor inconsistency between display names on orgs and some
other resources with display names on `coderd`. i.e. for organizations:
```
if req.DisplayName == "" {
	req.DisplayName = req.Name
}
```
For some other resources, e.g. users & groups, an empty string display
name is retained, and the CLI/Web UI just shows the actual name if the
display name is empty. For those, it's okay to have an empty string
default in the provider.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support org sync
2 participants