fix: support unmanaged roles on user resource #250
Merged
+86
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanndickson
commented
Aug 18, 2025
| @@ -77,7 +80,7 @@ func TestAccUserResource(t *testing.T) { | |||
| ImportStateVerify: true, | |||
| ImportStateId: "example", | |||
| // We can't pull the password from the API. | |||
| ImportStateVerifyIgnore: []string{"password"}, | |||
| ImportStateVerifyIgnore: []string{"password", "roles"}, | |||
There was a problem hiding this comment.
Because we're using null to signify that roles shouldn't be managed by Terraform, we have the same problem we have with the group resource: we don't know whether or not the null value was set in the config, or is null because it's an import. Frustratingly, the provider framework doesn't provide a way to differentiate the two.
deansheather
approved these changes
Aug 18, 2025
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A customer ran into an issue when creating an OIDC user while role sync was enabled on the deployment:
This is because we always call
UpdateUserRolesonCreateandUpdate.OIDC User roles cannot be managed via the API if role sync is used, as the API always returns an error on any role update request.
With this PR,
rolescan now be set tonullin the config, whereby the Terraform provider will not attempt to read or update the user's roles under any circumstances. This prevents config drift when roles are set via Role Sync.