chore: add groups to integration test #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 17, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ethanndickson and the rest of your teammates on |
f95a970 to
695f2f4
Compare
250ad4e to
e97e71c
Compare
695f2f4 to
7dc20eb
Compare
e97e71c to
40c3e02
Compare
ethanndickson
commented
Jul 17, 2024
|
|
||
| data "coderd_organization" "default" { | ||
| is_default = true | ||
| } |
There was a problem hiding this comment.
I'm not totally sure on this from a UX perspective - but we can't use name="default" because the first organisation, whilst it can be retrieved using the name default, actually has the name first-organization.
There was a problem hiding this comment.
and I'm 90% sure Terraform is always going to spit the dummy if we just replaced the given name?
3 tasks
7dc20eb to
24a0fe9
Compare
40c3e02 to
c0065c3
Compare
24a0fe9 to
962336f
Compare
c0065c3 to
3e749a6
Compare
962336f to
adb48de
Compare
3e749a6 to
39670c5
Compare
adb48de to
e313323
Compare
39670c5 to
2fca026
Compare
e313323 to
63f4357
Compare
2fca026 to
8222503
Compare
63f4357 to
ae0d572
Compare
8222503 to
2632693
Compare
ae0d572 to
aa86273
Compare
cae8c17 to
92ecb54
Compare
92ecb54 to
b35dec9
Compare
deansheather
approved these changes
Jul 22, 2024
This was referenced Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've decided these should go in the existing
user-testintegration test case since it's best to test the groups with users in them.