chore: update readme, add version warnings, examples #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ethanndickson and the rest of your teammates on |
a052493 to
e7838de
Compare
matifali
approved these changes
Aug 13, 2024
Comment on lines
23
to
38
| resource "coderd_template" "ubuntu-main" { | ||
| name = "ubuntu-main" | ||
| description = "The main template for developing on Ubuntu." | ||
| versions = [ | ||
| { | ||
| name = "stable-${var.TFC_CONFIGURATION_VERSION_GIT_COMMIT_SHA}" | ||
| description = "The stable version of the template." | ||
| directory = "./stable-template" | ||
| }, | ||
| { | ||
| name = "staging-${var.TFC_CONFIGURATION_VERSION_GIT_COMMIT_SHA}" | ||
| description = "The staging version of the template." | ||
| directory = "./staging-template" | ||
| } | ||
| ] | ||
| } |
There was a problem hiding this comment.
There was a problem hiding this comment.
We've just been operating on the assumption that the functionality is there, if people want it.
I only include this example as we currently don't have a great way to otherwise communicate that these versions in the list don't represent a single version on the Coder deployment, and rather are a 'branch' of versions. Though maybe that can be reasonably deduced with one item in the list?
There was a problem hiding this comment.
I agree that this example is a best demonstration of the full capability of the provider.
e7838de to
9628064
Compare
9628064 to
080352d
Compare
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #69.