Skip to content

fix: fix minimum coder version warning #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 16, 2024
Merged

Conversation

matifali
Copy link
Member

@matifali matifali commented Aug 15, 2024

It was incorrectly linked to 2.13.0.

@matifali matifali requested a review from ethanndickson August 15, 2024 15:51
@matifali matifali self-assigned this Aug 15, 2024
@matifali matifali requested a review from deansheather August 15, 2024 15:52
@matifali
Copy link
Member Author

@ethanndickson I don't know what Linter is unhappy about my PR.

@ethanndickson
Copy link
Member

@matifali Fixed. That was just golangci-lint, however the CI's using a newer version than is installed on our dogfood template.

@ethanndickson
Copy link
Member

ethanndickson commented Aug 16, 2024

The provider does work against Coder deployments going back to 2.10.1, even though those versions aren't technically supported.

Do we have any other projects that operate against a Coder deployment, that can be used against older, unsupported versions, absolutely fine? What Coder version do we say the software requires in those cases?

The IDE extensions download older slim binaries from the deployment, so I don't believe they're relevant.

@matifali
Copy link
Member Author

matifali commented Aug 16, 2024

Ok I will just change the link to 2.10.1 then for now.
The PR mainly addresses the wrong link. Because clicking 2.10.1 takes you to 2.13.0.
So just change the link for now and we can bump this version if/when we add new features that are only available in newer versions.

@matifali matifali merged commit 1a38271 into main Aug 16, 2024
13 checks passed
@ethanndickson ethanndickson deleted the matifali/min-version-fix branch August 19, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants