-
Notifications
You must be signed in to change notification settings - Fork 4
implement first pass at cached image data source #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
809e3d9
implement first pass at cached image data source
johnstcn 2a473d1
make cached_image data source test actually do the thing
johnstcn aabb12b
test now passes
johnstcn 7e0ea42
appease linter
johnstcn 076ec3c
make gen
johnstcn 92d8880
gitignore registry-cache
johnstcn 9104f2a
pull envbuilder image if not exist
johnstcn 5787130
run test registry before tf acc tests
johnstcn 951f24e
only test with tf 1.9 for now
johnstcn cb54e9d
add TODO
johnstcn 53e2f1a
.
johnstcn 361df6c
add test case for not found
johnstcn 40b7c55
extract testutil/registrytest package
johnstcn 7dcad7b
fixup! extract testutil/registrytest package
johnstcn 1cfe12d
update schema docs
johnstcn f817274
set image = builder_image if not exists
johnstcn ec1df4b
fixup! set image = builder_image if not exists
johnstcn 341aee7
fix quoting
johnstcn bacbca1
address PR feedback
johnstcn 50ff762
cleanup tmpDir after read
johnstcn 1de4e49
add TODO
johnstcn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want this to update to main or would it be better to default to the latest release version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm actually not sure what we'll want right now. Let's leave it at main for now and maybe later we can specify a particular version if needed.