add new 'includeCompletionsWithClasMemberSnippets' option (microsoft#136045)

gabritto · web-flow · commit d2aa181e6614 · 2021-10-28T14:07:11.000-07:00
diff --git a/extensions/typescript-language-features/package.json b/extensions/typescript-language-features/package.json
@@ -1110,6 +1110,12 @@
           "default": "allOpenProjects",
           "markdownDescription": "%typescript.workspaceSymbols.scope%",
           "scope": "window"
+        },
+        "typescript.suggest.includeCompletionsWithClassMemberSnippets": {
+          "type": "boolean",
+          "default": true,
+          "description": "%configuration.suggest.includeCompletionsWithClassMemberSnippets%",
+          "scope": "resource"
         }
       }
     },
diff --git a/extensions/typescript-language-features/package.nls.json b/extensions/typescript-language-features/package.nls.json
@@ -183,5 +183,6 @@
 	"codeActions.refactor.rewrite.property.generateAccessors.title": "Generate accessors",
 	"codeActions.refactor.rewrite.property.generateAccessors.description": "Generate 'get' and 'set' accessors",
 	"codeActions.source.organizeImports.title": "Organize imports",
-	"typescript.findAllFileReferences": "Find File References"
+	"typescript.findAllFileReferences": "Find File References",
+	"configuration.suggest.includeCompletionsWithClassMemberSnippets": "Enable/disable snippet completions for class members. Requires using TypeScript 4.5+ in the workspace"
 }
diff --git a/extensions/typescript-language-features/src/languageFeatures/fileConfigurationManager.ts b/extensions/typescript-language-features/src/languageFeatures/fileConfigurationManager.ts
@@ -201,6 +201,7 @@ export default class FileConfigurationManager extends Disposable {
 			generateReturnInDocTemplate: config.get<boolean>('suggest.jsdoc.generateReturns', true),
 			includeCompletionsForImportStatements: config.get<boolean>('suggest.includeCompletionsForImportStatements', true),
 			includeCompletionsWithSnippetText: config.get<boolean>('suggest.includeCompletionsWithSnippetText', true),
+			includeCompletionsWithClassMemberSnippets: config.get<boolean>('suggest.includeCompletionsWithClassMemberSnippets', true),
 			allowIncompleteCompletions: true,
 			displayPartsForJSDoc: true,
 			...getInlayHintsPreferences(config),

Original file line number	Diff line number	Diff line change
`@@ -1110,6 +1110,12 @@`
`1110`	`1110`	`"default": "allOpenProjects",`
`1111`	`1111`	`"markdownDescription": "%typescript.workspaceSymbols.scope%",`
`1112`	`1112`	`"scope": "window"`
	`1113`	`+ },`
	`1114`	`+ "typescript.suggest.includeCompletionsWithClassMemberSnippets": {`
	`1115`	`+ "type": "boolean",`
	`1116`	`+ "default": true,`
	`1117`	`+ "description": "%configuration.suggest.includeCompletionsWithClassMemberSnippets%",`
	`1118`	`+ "scope": "resource"`
`1113`	`1119`	`}`
`1114`	`1120`	`}`
`1115`	`1121`	`},`
Original file line number	Diff line number	Diff line change
`@@ -183,5 +183,6 @@`
`183`	`183`	`"codeActions.refactor.rewrite.property.generateAccessors.title": "Generate accessors",`
`184`	`184`	`"codeActions.refactor.rewrite.property.generateAccessors.description": "Generate 'get' and 'set' accessors",`
`185`	`185`	`"codeActions.source.organizeImports.title": "Organize imports",`
`186`		`- "typescript.findAllFileReferences": "Find File References"`
	`186`	`+ "typescript.findAllFileReferences": "Find File References",`
	`187`	`+ "configuration.suggest.includeCompletionsWithClassMemberSnippets": "Enable/disable snippet completions for class members. Requires using TypeScript 4.5+ in the workspace"`
`187`	`188`	`}`