change rmDirSync to rmSync #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes the issue from my comment on coder@db0490f#commitcomment-66284504
jsjoeio
approved these changes
Feb 9, 2022
There was a problem hiding this comment.
Oh fantastic! Thanks for adding that. TIL rmSync handles files.
@code-asher do you see any issues with merging this?
(Note: we'll also need to update in code-server)
jsjoeio
added a commit
to coder/code-server
that referenced
this pull request
Feb 11, 2022
This includes two fixes from coder/vscode: - coder/vscode#43 - coder/vscode#42
jsjoeio
added a commit
to coder/code-server
that referenced
this pull request
Feb 15, 2022
* chore: update vscode commit This includes two fixes from coder/vscode: - coder/vscode#43 - coder/vscode#42 * fix: use double-bracket in ext. e2e test
TinLe
pushed a commit
to TinLe/code-server
that referenced
this pull request
Apr 23, 2022
* chore: update vscode commit This includes two fixes from coder/vscode: - coder/vscode#43 - coder/vscode#42 * fix: use double-bracket in ext. e2e test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes the issue from my comment on db0490f#commitcomment-66284504
rmSync with recursive will handle files and directories, and is closer to rimraf as such