Skip to content

feat: add VS code notifications for workspace actions #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jun 27, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
simplify build status gate
  • Loading branch information
Kira-Pilot committed Jun 27, 2023
commit 53704d0f2111ab8b81e91f895c750fe6d3d0f7a6
10 changes: 2 additions & 8 deletions src/WorkspaceAction.ts
Original file line number Diff line number Diff line change
Expand Up @@ -73,14 +73,8 @@ export class WorkspaceAction {
}

filterWorkspacesImpendingAutostop(workspace: Workspace): workspace is WorkspaceWithDeadline {
// a workspace is eligible for autostop if the last build was successful,
// and the workspace is started,
// and it has a deadline
if (
workspace.latest_build.job.status !== "succeeded" ||
workspace.latest_build.transition !== "start" ||
!workspace.latest_build.deadline
) {
// a workspace is eligible for autostop if the workspace is running and it has a deadline
if (workspace.latest_build.status !== "running" || !workspace.latest_build.deadline) {
return false
}

Expand Down