feat: add options to support client tls #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylecarbs
approved these changes
Aug 22, 2023
|
@code-asher why might this fail? |
|
Ah I think the certificate fixtures I generated expired, for some reason I just assumed they had no expiration if I never specified one but apparently there is a default (30 days it seems?). I will change it to either generate them as part of the test or make the expiration really far in the future. |
adding configuration properties: coder.tlsCertFile coder.tlsKeyFile coder.tlsCaFile
79ca42a to
0ce86ea
Compare
code-asher
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding configuration properties:
fixes #126