Skip to content

Prevent parallel refreshes #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 1, 2024
Merged

Prevent parallel refreshes #202

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9042bd2
Prevent refreshing in parallel
code-asher Feb 1, 2024
b4f046b
Pass URL
code-asher Feb 1, 2024
6364228
Fix logout check
code-asher Feb 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Prevent refreshing in parallel 
While adding an automatic refresh I discovered it was easy to
accidentally cause two refreshes to go off at the same time which causes
some races.
  • Loading branch information
@code-asher
code-asher committed Feb 1, 2024
commit 9042bd22fb12eb64fa50ae101870514895cdaec6
61 changes: 45 additions & 16 deletions src/workspacesProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ export enum WorkspaceQuery {
export class WorkspaceProvider implements vscode.TreeDataProvider<vscode.TreeItem> {
private workspaces: WorkspaceTreeItem[] = []
private agentWatchers: Record<WorkspaceAgent["id"], { dispose: () => void; metadata?: AgentMetadataEvent[] }> = {}
private fetching = false

constructor(
private readonly getWorkspacesQuery: WorkspaceQuery,
Expand All @@ -22,26 +23,54 @@ export class WorkspaceProvider implements vscode.TreeDataProvider<vscode.TreeIte
this.fetchAndRefresh()
}

// fetchAndRefrehsh fetches new workspaces then re-renders the entire tree.
// fetchAndRefresh fetches new workspaces then re-renders the entire tree.
// Trying to call this while already refreshing is a no-op and will return
// immediately.
async fetchAndRefresh() {
const token = await this.storage.getSessionToken()
const workspacesTreeItem: WorkspaceTreeItem[] = []
if (this.fetching) {
return
}
this.fetching = true

Object.values(this.agentWatchers).forEach((watcher) => watcher.dispose())
// If the URL is set then we are logged in.
if (this.storage.getURL()) {
const resp = await getWorkspaces({ q: this.getWorkspacesQuery })
resp.workspaces.forEach((workspace) => {
const showMetadata = this.getWorkspacesQuery === WorkspaceQuery.Mine
if (showMetadata && token) {
const agents = extractAgents(workspace)
agents.forEach((agent) => this.monitorMetadata(agent.id, token)) // monitor metadata for all agents
}
const treeItem = new WorkspaceTreeItem(workspace, this.getWorkspacesQuery === WorkspaceQuery.All, showMetadata)
workspacesTreeItem.push(treeItem)
})

try {
this.workspaces = await this.fetch()
} catch (error) {
this.workspaces = []
}
this.workspaces = workspacesTreeItem

this.refresh()
this.fetching = false
}

/**
* Fetch workspaces and turn them into tree items. Throw an error if not
* logged in or the query fails.
*/
async fetch(): Promise<WorkspaceTreeItem[]> {
// Assume that no URL or no token means we are not logged in.
const url = this.storage.getURL()
const token = await this.storage.getSessionToken()
if (!url || !token) {
throw new Error("not logged in")
}

const resp = await getWorkspaces({ q: this.getWorkspacesQuery })

// We could have logged out while waiting for the query.
if (!url || !token) {
throw new Error("not logged in")
}

return resp.workspaces.map((workspace) => {
const showMetadata = this.getWorkspacesQuery === WorkspaceQuery.Mine
if (showMetadata) {
const agents = extractAgents(workspace)
agents.forEach((agent) => this.monitorMetadata(agent.id, token)) // monitor metadata for all agents
}
return new WorkspaceTreeItem(workspace, this.getWorkspacesQuery === WorkspaceQuery.All, showMetadata)
})
}

private _onDidChangeTreeData: vscode.EventEmitter<vscode.TreeItem | undefined | null | void> =
Expand Down