Skip to content

fix: remove unused date object #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 4, 2025
+5 −9
Merged

fix: remove unused date object #445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e47a74
remove unused date object
bcpeinhardt Mar 4, 2025
5d480af
yarn stuff
bcpeinhardt Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,9 @@ Some dependencies are not directly used in the source but are required anyway.
- `glob`, `nyc`, `vscode-test`, and `@vscode/test-electron` are currently unused
but we need to switch back to them from `vitest`.

The coder client is vendored from coder/coder. Every now and then, we should be running `yarn upgrade coder --latest`
to make sure we're using up to date versions of the client.

## Releasing

1. Check that the changelog lists all the important changes.
Expand Down
2 changes: 1 addition & 1 deletion src/api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ export async function waitForBuild(
}

// This fetches the initial bunch of logs.
const logs = await restClient.getWorkspaceBuildLogs(workspace.latest_build.id, new Date())
const logs = await restClient.getWorkspaceBuildLogs(workspace.latest_build.id)
logs.forEach((log) => writeEmitter.fire(log.output + "\r\n"))

// This follows the logs for new activity!
Expand Down
9 changes: 1 addition & 8 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1589,9 +1589,7 @@ co@3.1.0:

"coder@https://github.com/coder/coder#main":
version "0.0.0"
resolved "https://github.com/coder/coder#9eb797eb5a2bfb115db1fe8eccad78908a5f8ec1"
dependencies:
exec "^0.2.1"
resolved "https://github.com/coder/coder#975ea23d6f49a4043131f79036d1bf5166eb9140"

collapse-white-space@^1.0.2:
version "1.0.6"
Expand Down Expand Up @@ -2543,11 +2541,6 @@ eventsource@*, eventsource@^3.0.5:
dependencies:
eventsource-parser "^3.0.0"

exec@^0.2.1:
version "0.2.1"
resolved "https://registry.yarnpkg.com/exec/-/exec-0.2.1.tgz#2661f0bfc5532918629117cb9f80c7564af2c51f"
integrity sha512-lE5ZlJgRYh+rmwidatL2AqRA/U9IBoCpKlLriBmnfUIrV/Rj4oLjb63qZ57iBCHWi5j9IjLt5wOWkFYPiTfYAg==

expand-template@^2.0.3:
version "2.0.3"
resolved "https://registry.yarnpkg.com/expand-template/-/expand-template-2.0.3.tgz#6e14b3fcee0f3a6340ecb57d2e8918692052a47c"
Expand Down