Skip to content

feat: handle windows specific paths in log-path parameter #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: handle windows specific paths in log-path parameter #512

wants to merge 1 commit into from
+1 −1

Conversation

ibetitsmike
Copy link

@ibetitsmike ibetitsmike commented May 22, 2025 •
edited
Loading

Fixes: #430

matifali
matifali reviewed May 26, 2025
View reviewed changes
@ibetitsmike ibetitsmike force-pushed the mike/430-vs-code-win-path branch from 44e3dfa to ab2f929 Compare June 10, 2025 16:28
@bcpeinhardt
Copy link
Collaborator

bcpeinhardt commented Jun 10, 2025 •
edited
Loading

I suspect the issue was that claude nuked your lockfile (it likes to do that). Just reverting the lockfile fixed the build. I'll leave passing the test and lint checks up to you :)

@ibetitsmike ibetitsmike force-pushed the mike/430-vs-code-win-path branch from bdc35ba to 281fe1a Compare June 17, 2025 17:28
@ibetitsmike ibetitsmike force-pushed the mike/430-vs-code-win-path branch from 281fe1a to bd9d1ca Compare June 17, 2025 17:47
@ibetitsmike ibetitsmike reopened this Jun 17, 2025
@matifali matifali requested a review from jaggederest June 18, 2025 07:24
@jaggederest jaggederest requested a review from code-asher June 18, 2025 17:28
jaggederest
jaggederest reviewed Jun 18, 2025
View reviewed changes
Copy link

@jaggederest jaggederest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to me, but I am not yet competent to hand out the ✅ of approval so I've asked Asher to take a look 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaggederest jaggederest jaggederest left review comments

@matifali matifali matifali left review comments

@code-asher code-asher Awaiting requested review from code-asher

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proxy log directory doesn't handle Windows style \
4 participants
@ibetitsmike @bcpeinhardt @jaggederest @matifali