Skip to content

Toolchain config #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Feb 21, 2022
Merged

Toolchain config #194

merged 23 commits into from
Feb 21, 2022

Conversation

coder137
Copy link
Owner

@coder137 coder137 commented Feb 21, 2022

Instead of having all configurations on the Target level, we have common parameters on the Toolchain level (which can be used by the corresponding targets).

  • TargetInfo now requires Toolchain
  • Some TargetConfig parameters are shifted to ToolchainConfig

@codecov
Copy link

codecov bot commented Feb 21, 2022

Codecov Report

Merging #194 (da5b9b5) into main (2dedb35) will decrease coverage by 0.05%.
The diff coverage is 97.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #194      +/-   ##
==========================================
- Coverage   99.31%   99.25%   -0.05%     
==========================================
  Files          53       54       +1     
  Lines        1731     1739       +8     
  Branches      464      466       +2     
==========================================
+ Hits         1719     1726       +7     
- Misses          0        1       +1     
  Partials       12       12              
Impacted Files Coverage Δ
...c/lib/target/include/target/common/target_config.h 100.00% <ø> (+100.00%) ⬆️
...cc/lib/target/include/target/common/target_state.h 100.00% <ø> (ø)
buildcc/lib/target/include/target/target.h 100.00% <ø> (ø)
...lchain/include/toolchain/common/toolchain_config.h 0.00% <0.00%> (ø)
...uildcc/lib/toolchain/include/toolchain/toolchain.h 92.31% <75.00%> (-7.69%) ⬇️
buildcc/lib/target/include/target/target_info.h 100.00% <100.00%> (ø)
buildcc/lib/target/src/api/include_api.cpp 100.00% <100.00%> (ø)
buildcc/lib/target/src/api/pch_api.cpp 100.00% <100.00%> (ø)
buildcc/lib/target/src/api/source_api.cpp 100.00% <100.00%> (ø)
buildcc/lib/target/src/common/target_state.cpp 100.00% <100.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dedb35...da5b9b5. Read the comment docs.

@coder137 coder137 merged commit c9c2cd8 into main Feb 21, 2022
@coder137 coder137 deleted the toolchain_config branch February 21, 2022 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant