Skip to content

Refactor Register constructable class to Reg static class #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 39 commits into from
Apr 8, 2022
Merged

Refactor Register constructable class to Reg static class #204

merged 39 commits into from
Apr 8, 2022

Conversation

coder137
Copy link
Owner

@coder137 coder137 commented Apr 2, 2022

  • Register constructable class is now nested under Reg as Reg::Instance

coder137 added 24 commits March 28, 2022 21:20
@codecov
Copy link

codecov bot commented Apr 2, 2022 •
edited
Loading

Codecov Report

Merging #204 (84212c1) into main (b9df847) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #204      +/-   ##
==========================================
+ Coverage   98.97%   98.99%   +0.02%     
==========================================
  Files          62       62              
  Lines        1837     1874      +37     
  Branches      502      505       +3     
==========================================
+ Hits         1818     1855      +37     
  Misses          1        1              
  Partials       18       18
Impacted Files Coverage Δ
buildcc/lib/args/include/args/args.h 100.00% <ø> (ø)
buildcc/lib/args/include/args/register.h 100.00% <100.00%> (ø)
buildcc/lib/args/src/args.cpp 100.00% <100.00%> (ø)
buildcc/lib/args/src/register.cpp 99.24% <100.00%> (+0.15%) ⬆️
...ildcc/schema/include/schema/target_serialization.h 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9df847...84212c1. Read the comment docs.

coder137
coder137 commented Apr 2, 2022
View reviewed changes
coder137
coder137 commented Apr 2, 2022
View reviewed changes
@coder137 coder137 merged commit f51e232 into main Apr 8, 2022
@coder137 coder137 deleted the register_static branch April 8, 2022 06:23
@coder137 coder137 mentioned this pull request Apr 21, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@coder137