Skip to content

Assert Fatal thread behavior #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 22, 2022
Merged

Assert Fatal thread behavior #206

merged 8 commits into from
Apr 22, 2022

Conversation

coder137
Copy link
Owner

  • Threaded : throw std::exception()
  • Not Threaded : std::exit(1)

@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #206 (2f16a69) into main (69b0943) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #206      +/-   ##
==========================================
- Coverage   98.99%   98.99%   -0.00%     
==========================================
  Files          62       62              
  Lines        1882     1877       -5     
  Branches      505      504       -1     
==========================================
- Hits         1863     1858       -5     
  Misses          1        1              
  Partials       18       18              
Impacted Files Coverage Δ
buildcc/lib/env/include/env/assert_fatal.h 100.00% <ø> (ø)
buildcc/lib/env/include/env/storage.h 100.00% <100.00%> (ø)
buildcc/lib/env/src/storage.cpp 100.00% <100.00%> (ø)
buildcc/lib/target/src/generator/task.cpp 100.00% <100.00%> (ø)
...ildcc/lib/target/src/target/friend/compile_pch.cpp 97.59% <100.00%> (ø)
...ildcc/lib/target/src/target/friend/link_target.cpp 100.00% <100.00%> (ø)
buildcc/lib/target/src/target/tasks.cpp 100.00% <100.00%> (ø)
buildcc/schema/include/schema/path.h 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69b0943...2f16a69. Read the comment docs.

@coder137 coder137 merged commit e41bf00 into main Apr 22, 2022
@coder137 coder137 deleted the better_assert branch April 22, 2022 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant