Skip to content

Add Security Rules for Weak Cryptographic Algorithms and Insecure SSL #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Add Security Rules for Weak Cryptographic Algorithms and Insecure SSL #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4a9a885
use-of-sha1-java
Dec 16, 2024
6615907
use-of-md5-java
Dec 16, 2024
67064b6
weak-ssl-context-java
Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions rules/java/security/use-of-md5-java.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
id: use-of-md5-java
severity: warning
language: java
message: >-
Detected MD5 hash algorithm which is considered insecure. MD5 is not
collision resistant and is therefore not suitable as a cryptographic
signature. Use HMAC instead.
note: >-
[CWE-328] Use of Weak Hash.
[REFERENCES]
- https://owasp.org/Top10/A02_2021-Cryptographic_Failures
rule:
any:
- pattern: java.security.MessageDigest.getInstance($ALGO)
- pattern: java.security.MessageDigest.getInstance($ALGO, $$$)
- pattern: MessageDigest.getInstance($ALGO)
- pattern: MessageDigest.getInstance($ALGO, $$$)
constraints:
ALGO:
regex: 'MD5'
23 changes: 23 additions & 0 deletions rules/java/security/use-of-sha1-java.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
id: use-of-sha1-java
language: java
severity: warning
message: >-
Detected SHA1 hash algorithm which is considered insecure. SHA1 is not
collision resistant and is therefore not suitable as a cryptographic
signature. Instead, use PBKDF2 for password hashing or SHA256 or SHA512
for other hash function applications.
note: >-
[CWE-328] Use of Weak Hash.
[REFERENCES]
- https://owasp.org/Top10/A02_2021-Cryptographic_Failures
rule:
any:
- pattern: $DU.getSha1Digest().digest($$$)
- pattern: MessageDigest.getInstance($ALGO)
- pattern: MessageDigest.getInstance($ALGO,$$$)
- pattern: java.security.MessageDigest.getInstance($ALGO,$$$)
constraints:
ALGO:
regex: 'SHA1|SHA-1'


75 changes: 75 additions & 0 deletions rules/java/security/weak-ssl-context-java.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,75 @@
id: weak-ssl-context-java
language: java
severity: warning
message: >-
'An insecure SSL context was detected. TLS versions 1.0, 1.1, and all
SSL versions are considered weak encryption and are deprecated. Use
SSLContext.getInstance("TLSv1.2") for the best security.'
note: >-
[CWE-326] Inadequate Encryption Strength
[REFERENCES]
- https://tools.ietf.org/html/rfc7568
- https://tools.ietf.org/id/draft-ietf-tls-oldversions-deprecate-02.html

rule:
all:
- pattern: SSLContext.getInstance($CONTEXT)
- not:
pattern: SSLContext.getInstance("TLSv1.3")
- not:
pattern: SSLContext.getInstance("TLSv1.2")
constraints:
CONTEXT:
any:
- kind: string_literal
pattern: $TLS
not:
regex: ^['"`](TLSv1.2|TLSv1.3)['"`]$
- kind: identifier
inside:
stopBy: end
follows:
stopBy: end
any:
- kind: local_variable_declaration
- kind: field_declaration
all:
- has:
kind: type_identifier
regex: ^String$
- has:
stopBy: end
kind: variable_declarator
all:
- has:
kind: identifier
stopBy: end
pattern: $CONTEXT
- has:
kind: string_literal
pattern: $TLS
not:
regex: ^['"`](TLSv1.2|TLSv1.3)['"`]$
- kind: identifier
follows:
stopBy: end
any:
- kind: local_variable_declaration
- kind: field_declaration
all:
- has:
kind: type_identifier
regex: ^String$
- has:
stopBy: end
kind: variable_declarator
all:
- has:
kind: identifier
stopBy: end
pattern: $CONTEXT
- has:
kind: string_literal
pattern: $TLS
not:
regex: ^['"`](TLSv1.2|TLSv1.3)['"`]$
9 changes: 9 additions & 0 deletions tests/__snapshots__/use-of-md5-java-snapshot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
id: use-of-md5-java
snapshots:
? |
MessageDigest md5Digest = MessageDigest.getInstance("MD5");
: labels:
- source: MessageDigest.getInstance("MD5")
style: primary
start: 26
end: 58
31 changes: 31 additions & 0 deletions tests/__snapshots__/use-of-sha1-java-snapshot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
id: use-of-sha1-java
snapshots:
? |
MessageDigest sha1Digest = MessageDigest.getInstance("SHA1");
: labels:
- source: MessageDigest.getInstance("SHA1")
style: primary
start: 27
end: 60
? |
MessageDigest sha1Digest = MessageDigest.getInstance("SHA1", "SUN");
: labels:
- source: MessageDigest.getInstance("SHA1", "SUN")
style: primary
start: 27
end: 67
? |
byte[] hashValue = DigestUtils.getSha1Digest().digest(password.getBytes());
: labels:
- source: DigestUtils.getSha1Digest().digest(password.getBytes())
style: primary
start: 19
end: 74
? |
java.security.MessageDigest md = java.security.MessageDigest.getInstance("SHA1", "SUN");
DigestUtils.getSha1Digest().digest(password.getBytes());
: labels:
- source: java.security.MessageDigest.getInstance("SHA1", "SUN")
style: primary
start: 33
end: 87
37 changes: 37 additions & 0 deletions tests/__snapshots__/weak-ssl-context-java-snapshot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
id: weak-ssl-context-java
snapshots:
? |
SSLContext ctx = SSLContext.getInstance("SSL");
: labels:
- source: SSLContext.getInstance("SSL")
style: primary
start: 17
end: 46
? |
SSLContext ctx = SSLContext.getInstance("SSLv3");
: labels:
- source: SSLContext.getInstance("SSLv3")
style: primary
start: 17
end: 48
? |
SSLContext ctx = SSLContext.getInstance("TLS");
: labels:
- source: SSLContext.getInstance("TLS")
style: primary
start: 17
end: 46
? |
SSLContext ctx = SSLContext.getInstance("TLSv1");
: labels:
- source: SSLContext.getInstance("TLSv1")
style: primary
start: 17
end: 48
? |
SSLContext ctx = SSLContext.getInstance("TLSv1.1");
: labels:
- source: SSLContext.getInstance("TLSv1.1")
style: primary
start: 17
end: 50
7 changes: 7 additions & 0 deletions tests/java/use-of-md5-java-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
id: use-of-md5-java
valid:
- |
MessageDigest md5Digest = MessageDigest.getInstance("SHA-512");
invalid:
- |
MessageDigest md5Digest = MessageDigest.getInstance("MD5");
18 changes: 18 additions & 0 deletions tests/java/use-of-sha1-java-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
id: use-of-sha1-java
valid:
- |
java.io.File fileTarget = new java.io.File(
new java.io.File(org.owasp.benchmark.helpers.Utils.TESTFILES_DIR),
"passwordFile.txt");
invalid:
- |
java.security.MessageDigest md = java.security.MessageDigest.getInstance("SHA1", "SUN");
DigestUtils.getSha1Digest().digest(password.getBytes());
- |
MessageDigest sha1Digest = MessageDigest.getInstance("SHA1", "SUN");
- |
byte[] hashValue = DigestUtils.getSha1Digest().digest(password.getBytes());
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Remove duplicate test case.

The test case for DigestUtils.getSha1Digest() appears twice (lines 14 and 18).

  - |
    byte[] hashValue = DigestUtils.getSha1Digest().digest(password.getBytes());
  - |
    MessageDigest sha1Digest = MessageDigest.getInstance("SHA1");
- - |
-   byte[] hashValue = DigestUtils.getSha1Digest().digest(password.getBytes());

Also applies to: 18-18

- |
MessageDigest sha1Digest = MessageDigest.getInstance("SHA1");
- |
byte[] hashValue = DigestUtils.getSha1Digest().digest(password.getBytes());
19 changes: 19 additions & 0 deletions tests/java/weak-ssl-context-java-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
id: weak-ssl-context-java
valid:
- |
SSLContext ctx = SSLContext.getInstance("TLSv1.2");
- |
SSLContext ctx = SSLContext.getInstance("TLSv1.3");
- |
SSLContext ctx = SSLContext.getInstance(getSslContext());
invalid:
- |
SSLContext ctx = SSLContext.getInstance("SSL");
- |
SSLContext ctx = SSLContext.getInstance("TLS");
- |
SSLContext ctx = SSLContext.getInstance("TLSv1");
- |
SSLContext ctx = SSLContext.getInstance("SSLv3");
- |
SSLContext ctx = SSLContext.getInstance("TLSv1.1");