Skip to content

⬆️ Override esbuild@<=0.24.2 to ^0.25.0 #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2025
Merged

⬆️ Override esbuild@<=0.24.2 to ^0.25.0 #76

merged 1 commit into from
Sep 2, 2025

Conversation

NatoBoram
Copy link
Collaborator

@NatoBoram NatoBoram commented Sep 2, 2025 •
edited by coderabbitai bot
Loading

📝 Description

ignoredBuiltDependencies:
  - esbuild

overrides:
  esbuild@<=0.24.2: ^0.25.0

📓 References

Summary by CodeRabbit

  • Chores

    • Standardized dependency resolution to use esbuild ^0.25.0 across workspaces.
    • Ignored esbuild as a built dependency to streamline installations.

  • Bug Fixes

    • Eliminated inconsistencies caused by older esbuild versions during installs.

Impact:

  • More reliable installs and builds across the workspace.
  • Reduced friction from version mismatches and rebuilds.

@NatoBoram NatoBoram self-assigned this Sep 2, 2025
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Sep 2, 2025 •
edited
Loading

📝 Walkthrough

Walkthrough

Updated pnpm-workspace.yaml to adjust esbuild handling: added ignoredBuiltDependencies for esbuild and set an overrides rule to force esbuild versions <=0.24.2 to ^0.25.0.

Changes

Cohort / File(s) Summary of Changes
Workspace dependency policy
pnpm-workspace.yaml		 Added ignoredBuiltDependencies: [esbuild]; added overrides to pin esbuild@<=0.24.2 to ^0.25.0 during resolution/install.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

dependencies

Pre-Merge Checks (1 passed, 2 warnings)

❌ Failed Checks (2 warnings)
Check Name Status Explanation Resolution
Title Check ⚠️ Warning The title only mentions overriding esbuild but omits the addition of ignoredBuiltDependencies for esbuild, so it doesn’t fully reflect the changes. Revise the pull request title to include both updates, for example: "Add ignoredBuiltDependencies for esbuild and override esbuild@<=0.24.2 to ^0.25.0 in pnpm-workspace.yaml".
Description Check ⚠️ Warning The description still contains placeholder comments and lacks a concise summary, rationale for the change, explanation of why this is the best solution, and a narrative of what was done. Fill in the template by adding a short summary under 60 characters, explain why the pull request is needed and why this solution was chosen, and describe the specific changes made.
✅ Passed Checks (1 passed)
Check Name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bugfix/override-esbuild
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@NatoBoram NatoBoram enabled auto-merge September 2, 2025 17:34
coderabbitai[bot]
coderabbitai bot reviewed Sep 2, 2025
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
pnpm-workspace.yaml (2)

4-5: Optional: pin Node via workspace config to prevent incompatible installs.

If your repo targets Node < 18 anywhere, installs may fail after this override. Consider adding useNodeVersion (or nodeVersion + engineStrict) in pnpm-workspace.yaml to enforce a compatible runtime in CI/dev. (pnpm.io)

4-5: Wrap override key/value in quotes and reference GHSA advisory

Override correctly remaps all esbuild@<=0.24.2 instances to ^0.25.0 (no vulnerable versions remain). Please update pnpm-workspace.yaml:

 overrides:
-  esbuild@<=0.24.2: ^0.25.0
+  # GHSA-67mh-4wv8-2f99
+  "esbuild@<=0.24.2": "^0.25.0"

Also verify your Node engine in package.json is set to ≥18 to match esbuild’s requirement since 0.23.x.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 5ec0cdb and 3fa6013.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • pnpm-workspace.yaml (1 hunks)
🔇 Additional comments (1)
pnpm-workspace.yaml (1)

1-2: Confirm esbuild still functions with ignoredBuiltDependencies: [esbuild]
The workspace script didn’t match any packages—rerun in a folder that depends on esbuild (for example, packages/your-app) after pnpm install:

cd packages/your-app
pnpm exec node -e "console.log('esbuild', require('esbuild').version)"
pnpm exec esbuild --version

If require('esbuild') or the esbuild CLI fails, remove the ignoredBuiltDependencies: [esbuild] entry or switch to using onlyBuiltDependencies.

@NatoBoram NatoBoram added this pull request to the merge queue Sep 2, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 2, 2025
@NatoBoram NatoBoram added this pull request to the merge queue Sep 2, 2025
Merged via the queue into main with commit 1ff3f21 Sep 2, 2025
3 checks passed
@NatoBoram NatoBoram deleted the bugfix/override-esbuild branch September 2, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

Assignees

@NatoBoram NatoBoram

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@NatoBoram