fix: improved server side cleanup after ingest #477
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor repository cleanup from background task to immediate cleanup
Overview
This PR refactors the repository cleanup mechanism from a background cleanup task to immediate cleanup after each processing operation, improving resource management and simplifying the codebase.
Changes Made
🧹 Cleanup Strategy Change
🔧 Key Modifications
src/server/main.py
lifespan
import and usage from FastAPI app initializationsrc/server/query_processor.py
_cleanup_repository()
function for immediate cleanupprocess_query()
:shutil.rmtree()
with proper error handling and loggingsrc/server/server_utils.py
lifespan()
context manager_remove_old_repositories()
background task_process_folder()
helper function_append_line()
utility functionasyncio
,shutil
,time
,contextlib
,pathlib
)src/server/server_config.py
DELETE_REPO_AFTER
constant (no longer needed)