Skip to content

Commit fb28e64

Browse files
committed
merge revision(s) 53810: [Backport ruby#12044]
* net/ftp.rb: add NullSocket#closed? to fix closing not opened connection. [Fix rubyGH-1232] git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_1@54277 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
1 parent facd025 commit fb28e64

File tree

4 files changed

+18
-1
lines changed

4 files changed

+18
-1
lines changed

ChangeLog

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
Fri Mar 25 18:30:55 2016 Anthony Dmitriyev <antstorm@gmail.com>
2+
3+
* net/ftp.rb: add NullSocket#closed? to fix closing not opened
4+
connection. [Fix GH-1232]
5+
16
Fri Mar 25 18:26:40 2016 Nobuyoshi Nakada <nobu@ruby-lang.org>
27

38
* numeric.c (num_step_scan_args): comparison String with Numeric

lib/net/ftp.rb

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1070,6 +1070,10 @@ class NullSocket
10701070
def read_timeout=(sec)
10711071
end
10721072

1073+
def closed?
1074+
true
1075+
end
1076+
10731077
def close
10741078
end
10751079

test/net/ftp/test_ftp.rb

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,14 @@ def test_not_connected
2323
end
2424
end
2525

26+
def test_closed_when_not_connected
27+
ftp = Net::FTP.new
28+
assert_equal(true, ftp.closed?)
29+
assert_nothing_raised(Net::FTPConnectionError) do
30+
ftp.close
31+
end
32+
end
33+
2634
def test_connect_fail
2735
server = create_ftp_server { |sock|
2836
sock.print("421 Service not available, closing control connection.\r\n")

version.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#define RUBY_VERSION "2.1.9"
22
#define RUBY_RELEASE_DATE "2016-03-25"
3-
#define RUBY_PATCHLEVEL 474
3+
#define RUBY_PATCHLEVEL 475
44

55
#define RUBY_RELEASE_YEAR 2016
66
#define RUBY_RELEASE_MONTH 3

0 commit comments

Comments
 (0)