Update Chart.js to version 2.1.6 #17
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@coderbydesign would you like to take a look at this PR? It's really important to have the most recent version of Chart.js available for Rails apps. |
|
@pwcoleman would you mind keeping previous file permissions? I know file permissions aren't relevant, but it will keep your PR very focused on strictly updating the Chart.js only - and thus not having any other side effect on users' projects. Also, you might probably consider ignoring file permissions at all with: |
|
Upgraded to 2.4.0 in #19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to the most recent version https://github.com/chartjs/Chart.js/releases/tag/2.1.6