Skip to content

Fix warnings raised by HTMLProofer #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 29, 2023
Merged

Fix warnings raised by HTMLProofer #105

merged 2 commits into from
Jul 29, 2023

Conversation

yasulab
Copy link
Member

@yasulab yasulab commented Jul 29, 2023 •
edited
Loading

@kwaka1208 @takusandayooo テスト (HTMLProofer) を実行して出てきた警告を一通り直しました!

📝 補足: HTMLProofer は静的サイトジェネレーター (Jekyll など) 用のチェックツールです 🤖 ✅
https://github.com/gjtorikian/html-proofer#readme

Before

$ bundle exec rake test

...

Checking 63 internal links
Checking internal link hashes in 2 files
Ran on 22 files!

For the Images check, the following failures were found:

* At _site/index.html:125:
  image /img/2023/logo_640x160.svg does not have an alt attribute

* At _site/index.html:131:
  image /img/2023/mv-fumanara.png does not have an alt attribute

* At _site/index.html:135:
  image /img/2023/deco.svg does not have an alt attribute

* At _site/index.html:140:
  image /img/2023/52554972726_b2da260763_o.jpg does not have an alt attribute

* At _site/index.html:164:
  image /img/2023/coderdojo_logo.jpg does not have an alt attribute

* At _site/index.html:193:
  image /img/2023/top/map.png does not have an alt attribute

* At _site/index.html:215:
  image /img/2023/deco.svg does not have an alt attribute

For the Links check, the following failures were found:

* At _site/index.html:483:
  http://crssrds.jp/aboutme/ is not an HTTPS link

* At _site/posts/owakon/index.html:161:
  http://www.amazon.co.jp/-/e/B00DUV6S3E/ is not an HTTPS link

* At _site/sessions.html:219:
  http://www.amazon.co.jp/-/e/B00DUV6S3E/ is not an HTTPS link

After

$ bundle exec rake test

...

Checking 63 internal links
Checking internal link hashes in 2 files
Ran on 22 files!


HTML-Proofer finished successfully.

@yasulab yasulab changed the title Fix warnings raised by HTML Proofer Fix warnings raised by HTMLProofer Jul 29, 2023
@kwaka1208 kwaka1208 merged commit 6761865 into main Jul 29, 2023
@kwaka1208 kwaka1208 deleted the fix-warnings-raised-by-html-proofer branch July 29, 2023 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwaka1208 kwaka1208 Awaiting requested review from kwaka1208

@takusandayooo takusandayooo Awaiting requested review from takusandayooo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yasulab @kwaka1208