Skip to content

Fixes #189 #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fixes #189 #190

wants to merge 1 commit into from

Conversation

ScottEAdams
Copy link
Contributor

Fixes logic so that all "filenames" are downloaded.

CITIES_FILES = {
    'city': {
       'filenames': [
           "cities1000.zip",
           "US.zip",
           "GB.zip",
           "SE.zip",
           "FI.zip",
           "NO.zip"
       ],
       'urls':      ['http://download.geonames.org/export/dump/'+'{filename}']
    },
}

@ScottEAdams
Fixes #189
39c8053 
Fixes logic so that all "filenames" are downloaded.
@blag
Copy link
Collaborator

blag commented Jan 15, 2018

Can you rebase this on master and do a force push? I just added a commit that should fix the tests. It should merge cleanly.

@ScottEAdams
Copy link
Contributor Author

#191

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ScottEAdams @blag