Skip to content

Feature/validate commit order #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2020
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
log commit order warnings
Signed-off-by: shmck <shawn.j.mckay@gmail.com>
  • Loading branch information
ShMcK committed Jun 4, 2020
commit 57946077282b91ac35c7a4fa84a13fc1900a4666
11 changes: 10 additions & 1 deletion src/utils/commitOrder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,15 @@ export function validateCommitOrder(positions: string[]): boolean {
previous = current;
});

// TODO: log errors based on index
if (errors.length) {
console.warn("Found commit positions out of order");
positions.forEach((position, index) => {
if (errors.includes(index)) {
console.warn(`${position} <-`);
} else {
console.log(position);
}
});
}
return !errors.length;
}