Skip to content

Feature/no validate build #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 27, 2020
Merged

Feature/no validate build #53

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
316b035
no-validate
ShMcK Jun 25, 2020
c965ff4
block tutorial validation
ShMcK Jun 27, 2020
62de1ba
show defaults in help
ShMcK Jun 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
no-validate 
Signed-off-by: shmck <shawn.j.mckay@gmail.com>
  • Loading branch information
@ShMcK
ShMcK committed Jun 25, 2020
commit 316b0354dc51aef70d1e2aca5af47a0e7fe21873
16 changes: 12 additions & 4 deletions src/build.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ type BuildArgs = {
markdown: string;
yaml: string;
output: string;
noValidate: boolean;
};

async function build(args: string[]) {
Expand All @@ -41,6 +42,8 @@ async function build(args: string[]) {
// -o --output - default coderoad.json
const output =
getArg(args, { name: "output", alias: "o" }) || "tutorial.json";
const noValidate =
getArg(args, { name: "no-validate", alias: "nv" }) !== "false";

console.log(`Building CodeRoad ${output}...`);

Expand All @@ -49,6 +52,7 @@ async function build(args: string[]) {
output,
markdown,
yaml,
noValidate,
};
} catch (e) {
console.error("Error parsing build logs");
Expand Down Expand Up @@ -139,10 +143,14 @@ async function build(args: string[]) {

// validate tutorial based on tutorial json schema
try {
const valid = validateSchema(tutorialSchema, tutorial);
if (!valid) {
console.error("Tutorial validation failed. See above to see what to fix");
return;
if (!options.noValidate) {
const valid = validateSchema(tutorialSchema, tutorial);
if (!valid) {
console.error(
"Tutorial validation failed. See above to see what to fix"
);
return;
}
}
} catch (e) {
console.error("Error validating tutorial schema:");
Expand Down