Skip to content

fix test runner throttle #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2020
+2 −2
Merged

fix test runner throttle #309

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/services/testRunner/throttle.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ const THROTTLE_OFFSET = 300 // ms

export const throttle = (): Date | null => {
const now = new Date()
if (now.getTime() > lastRun.getTime() + THROTTLE_OFFSET) {
if (+now > +lastRun + THROTTLE_OFFSET) {
lastRun = now
return lastRun
}
Expand All @@ -14,4 +14,4 @@ export const throttle = (): Date | null => {

// quick solution to prevent processing multiple results
// NOTE: may be possible to kill child process early if we migrate to tasks
export const debounce = (startTime: Date): boolean => lastRun === startTime
export const debounce = (startTime: Date): boolean => +lastRun < +startTime + THROTTLE_OFFSET