Skip to content

properly declare vars to avoid global scope #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2013
Merged

properly declare vars to avoid global scope #1

merged 1 commit into from
Nov 13, 2013

Conversation

junosuarez
Copy link
Contributor

current implementation leaks global variables for _

@coderoshi
Copy link
Owner

+1 coolio, thanks. Though I need to upgrade to a newer node and use const

coderoshi added a commit that referenced this pull request Nov 13, 2013
@coderoshi
Merge pull request #1 from jden/fix-var-declaration
e02d2cb 
properly declare vars to avoid global scope
@coderoshi coderoshi merged commit e02d2cb into coderoshi:master Nov 13, 2013
@junosuarez
Copy link
Contributor Author

+1 for const. Make sure you declare the package.json engines field if you have something like that which potentially breaks backwards compatibility with an older v8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@junosuarez @coderoshi