Typeof comparison should always use triple equality

tersmitten · tersmitten · commit e05edededa83 · 2013-06-15T15:53:48.000+02:00
diff --git a/functions/array/array_merge_recursive.js b/functions/array/array_merge_recursive.js
@@ -18,7 +18,7 @@ function array_merge_recursive (arr1, arr2) {
   } else if ((arr1 && (arr1 instanceof Object)) && (arr2 && (arr2 instanceof Object))) {
     for (idx in arr2) {
       if (idx in arr1) {
-        if (typeof arr1[idx] == 'object' && typeof arr2 == 'object') {
+        if (typeof arr1[idx] === 'object' && typeof arr2 === 'object') {
           arr1[idx] = this.array_merge(arr1[idx], arr2[idx]);
         } else {
           arr1[idx] = arr2[idx];
diff --git a/functions/funchand/call_user_func.js b/functions/funchand/call_user_func.js
@@ -11,7 +11,7 @@ function call_user_func (cb) {
     func = (typeof this[cb] === 'function') ? this[cb] : func = (new Function(null, 'return ' + cb))();
   }
   else if (Object.prototype.toString.call(cb) === '[object Array]') {
-    func = (typeof cb[0] == 'string') ? eval(cb[0] + "['" + cb[1] + "']") : func = cb[0][cb[1]];
+    func = (typeof cb[0] === 'string') ? eval(cb[0] + "['" + cb[1] + "']") : func = cb[0][cb[1]];
   }
   else if (typeof cb === 'function') {
     func = cb;
diff --git a/functions/funchand/call_user_func_array.js b/functions/funchand/call_user_func_array.js
@@ -15,7 +15,7 @@ function call_user_func_array (cb, parameters) {
     func = (typeof this[cb] === 'function') ? this[cb] : func = (new Function(null, 'return ' + cb))();
   }
   else if (Object.prototype.toString.call(cb) === '[object Array]') {
-    func = (typeof cb[0] == 'string') ? eval(cb[0] + "['" + cb[1] + "']") : func = cb[0][cb[1]];
+    func = (typeof cb[0] === 'string') ? eval(cb[0] + "['" + cb[1] + "']") : func = cb[0][cb[1]];
   }
   else if (typeof cb === 'function') {
     func = cb;
diff --git a/functions/funchand/forward_static_call.js b/functions/funchand/forward_static_call.js
@@ -8,7 +8,7 @@ function forward_static_call (cb, parameters) {
   var func;
 
   if (typeof cb === 'string') {
-    if (typeof this[cb] == 'function') {
+    if (typeof this[cb] === 'function') {
       func = this[cb];
     } else {
       func = (new Function(null, 'return ' + cb))();
diff --git a/functions/funchand/forward_static_call_array.js b/functions/funchand/forward_static_call_array.js
@@ -10,7 +10,7 @@ function forward_static_call_array (cb, parameters) {
   var func;
 
   if (typeof cb === 'string') {
-    if (typeof this[cb] == 'function') {
+    if (typeof this[cb] === 'function') {
       func = this[cb];
     } else {
       func = (new Function(null, 'return ' + cb))();
diff --git a/functions/url/base64_decode.js b/functions/url/base64_decode.js
@@ -13,7 +13,7 @@ function base64_decode (data) {
   // *     returns 1: 'Kevin van Zonneveld'
   // mozilla has this native
   // - but breaks in 2.0.0.12!
-  //if (typeof this.window['atob'] == 'function') {
+  //if (typeof this.window['atob'] === 'function') {
   //    return atob(data);
   //}
   var b64 = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/=";
diff --git a/functions/url/base64_encode.js b/functions/url/base64_encode.js
@@ -11,7 +11,7 @@ function base64_encode (data) {
   // *     returns 1: 'S2V2aW4gdmFuIFpvbm5ldmVsZA=='
   // mozilla has this native
   // - but breaks in 2.0.0.12!
-  //if (typeof this.window['btoa'] == 'function') {
+  //if (typeof this.window['btoa'] === 'function') {
   //    return btoa(data);
   //}
   var b64 = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/=";

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@ function call_user_func (cb) {`
`11`	`11`	`func = (typeof this[cb] === 'function') ? this[cb] : func = (new Function(null, 'return ' + cb))();`
`12`	`12`	`}`
`13`	`13`	`else if (Object.prototype.toString.call(cb) === '[object Array]') {`
`14`		`- func = (typeof cb[0] == 'string') ? eval(cb[0] + "['" + cb[1] + "']") : func = cb[0][cb[1]];`
	`14`	`+ func = (typeof cb[0] === 'string') ? eval(cb[0] + "['" + cb[1] + "']") : func = cb[0][cb[1]];`
`15`	`15`	`}`
`16`	`16`	`else if (typeof cb === 'function') {`
`17`	`17`	`func = cb;`
Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@ function call_user_func_array (cb, parameters) {`
`15`	`15`	`func = (typeof this[cb] === 'function') ? this[cb] : func = (new Function(null, 'return ' + cb))();`
`16`	`16`	`}`
`17`	`17`	`else if (Object.prototype.toString.call(cb) === '[object Array]') {`
`18`		`- func = (typeof cb[0] == 'string') ? eval(cb[0] + "['" + cb[1] + "']") : func = cb[0][cb[1]];`
	`18`	`+ func = (typeof cb[0] === 'string') ? eval(cb[0] + "['" + cb[1] + "']") : func = cb[0][cb[1]];`
`19`	`19`	`}`
`20`	`20`	`else if (typeof cb === 'function') {`
`21`	`21`	`func = cb;`