Merge pull request #260 from codebender/bad_likes

just3ws · just3ws · commit 8e35408dc19b · 2014-12-13T22:39:11.000-06:00
destroy zombie likes when likable is invalid - Bounty 456
diff --git a/app/jobs/process_like_job.rb b/app/jobs/process_like_job.rb
@@ -8,10 +8,13 @@ def perform(process_type, like_id)
     case process_type
       when 'associate_to_user'
         begin
-          like.user_id = User.find_by_tracking_code(like.tracking_code)
-          like.save!
-        rescue ActiveRecord::RecordNotUnique => ex
-          ap ex
+          if user = User.find_by_tracking_code(like.tracking_code)
+            like.user = user
+            like.save!
+          else
+            like.destroy
+          end
+        rescue ActiveRecord::RecordNotUnique, ActiveRecord::RecordInvalid => ex
           like.destroy
         end
     end
diff --git a/spec/jobs/process_like_job_spec.rb b/spec/jobs/process_like_job_spec.rb
@@ -6,4 +6,49 @@
     end
   end
 
+  describe 'processing' do
+    let(:user) { Fabricate(:user, tracking_code: 'fake_tracking_code') }
+    let(:protip) { Fabricate(:protip) }
+
+    it 'associates the zombie like to the correct user' do
+      zombie_like = Fabricate(:like, likable: protip,
+        tracking_code: user.tracking_code)
+
+      ProcessLikeJob.new.perform('associate_to_user', zombie_like.id)
+
+      zombie_like.reload
+
+      expect(zombie_like.user_id).to eql user.id
+    end
+
+    it 'destroys like that are invalid' do
+      invalid_like = Like.new(value: 1, tracking_code: user.tracking_code)
+      invalid_like.save(validate: false)
+
+      ProcessLikeJob.new.perform('associate_to_user', invalid_like.id)
+
+      expect(Like.where(id: invalid_like.id)).not_to exist
+    end
+
+    it 'destroys likes that are non-unique' do
+      original_like = Fabricate(:like, user: user, likable: protip)
+
+      duplicate_like = Fabricate(:like, likable: protip,
+        tracking_code: user.tracking_code)
+
+      ProcessLikeJob.new.perform('associate_to_user', duplicate_like.id)
+
+      expect(Like.where(id: duplicate_like.id)).not_to exist
+    end
+
+    it 'destroys likes if no user with the tracking code exists' do
+      unassociatable_like = Fabricate(:like, likable: protip,
+        tracking_code: 'unassociatable_tracking_code')
+
+      ProcessLikeJob.new.perform('associate_to_user', unassociatable_like.id)
+
+      expect(Like.where(id: unassociatable_like.id)).not_to exist
+    end
+  end
+
 end
