destroy zombie likes when likable is invalid - Bounty 456 #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 I think you need to rerun the build |
|
seems like the build failed while downloading gems... oh TravisCI... |
| like.save! | ||
| rescue ActiveRecord::RecordNotUnique => ex | ||
| ap ex | ||
| rescue ActiveRecord::RecordNotUnique, ActiveRecord::RecordInvalid => ex | ||
| like.destroy |
There was a problem hiding this comment.
We can remove this line. The like was never saved, destroying it make no sense.
There was a problem hiding this comment.
The purpose of this job is the clean up zombie Likes. Zombie meaning not having the user_id set on the Like record. So we either want to assign the user_id or destroy it
|
Are we good on the conversation @codebender and @seuros on this PR? |
- or when a Like tracking code doesn’t associate to a user
7e95b2d to
27b3f58
Compare
|
@seuros ok with this ^^ ? |
just3ws
added a commit
that referenced
this pull request
Dec 14, 2014
destroy zombie likes when likable is invalid - Bounty 456
|
nice 😸 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG: ActiveRecord::RecordInvalid: Validation failed: Likable can't be blank - Bounty 456
The code will now handle when the zombie like has an invalid likable 😸