Skip to content

View stats for Protip cards - WIP #290 #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2014

Conversation

Mileshosky
Copy link
Contributor

Protip cards don't show view stats unless views are over 50 now.

coderwall_com___establishing_geek_cred_since_1305712800

@Mileshosky
Copy link
Contributor Author

I'm going to see if I can clean up the styling to make the footer details stick to the bottom of the card.

@just3ws
Copy link
Contributor

just3ws commented Jul 26, 2014

Are you going to do the styling in a separate PR @Mileshosky or is this ready to merge?

@Mileshosky
Copy link
Contributor Author

I'll take care of it in this PR, should be a matter of 15 minutes or so. Thanks!

@Mileshosky
Copy link
Contributor Author

@just3ws this is ready to merge, the styling is going to require a decent amount or reconstruction to get the desired effect, so I'm going to hold off on that for the moment.

I'll create another PR when I can take some time to do the styling and ensure there's no side effects with the changes.

just3ws added a commit that referenced this pull request Jul 26, 2014
@just3ws just3ws merged commit c04dea9 into coderwall:master Jul 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants