I added the odt and txt formats for Resume uploads, adjusted the user controller update to not raise an exception, and created a basic routing spec for the /resume_uploads action.

Feel free to merge this morning as you are comfortable, to get the fix live. I don't have time for a controller spec this am, but will be happy to add it this eve / when I work on the other cleanup and refactors.

My preference is to keep the separate ResumeUploadsController. We don't need to overload the Users controller with custom actions every time we want to do something like this. This is a single action purpose driven controller.

Thank you.
We can use a controller concern in this case.

The link will be post('users/resume')

@seuros, I still wouldn't consider using concerns in place of having a dedicated controller and action. Uploading a resume is not a concern (like session management helpers), it's a first class action and concept that should be given its own controller (and conceptual) space.

I don't think it need a whole controller for now since you using just 1 action anyway , an action will be fine.

If you want to use a controller, then nest it under Users module, and have /users/resume respond to (get, post, delete) => (show, create, destroy)

I'm open to going that route in the next round of changes / refactors. This works for the moment, and was intended to get a critical fix live - I don't see anything wrong with this structure for our immediate needs.

I appreciate the direction and review seuros

I like the latter approach. Hybrid, better routing with less crowded controller.

@Mileshosky
Thank you for your work.
I'm merging this for now, and we will test it in prod. Waiting for the others tests so we can close the bounty

While i'm thinking about it, please remove the image from the uploads as well . Nobody should give an image as CV. We need to be able to analyze the text from it and possibly in the future convert it to different format.
Also recruiters are expert in ctrl+f to find their keywords and image don't provide that.

Thanks guys.

@just3ws - can you clarify 'latter' approach. I think you're meaning the controller nested under users module that seuros mentioned. Just want to clarify.

@seuros, I'll pull out the image formats from ResumeUploader next.

Thanks guys!

Yes