Skip to content

Avatar is not present when Developer Strategy is used #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2014
Merged

Avatar is not present when Developer Strategy is used #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/models/concerns/user_oauth.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,8 @@ def for_omniauth(auth)
backup_email: auth[:info][:email],
location: location_from(auth))
#FIXME VCR raise an error when we try to download the image
user.avatar.download! avatar_url_for(auth) unless Rails.env.test?
avatar_url = avatar_url_for(auth)
user.avatar.download! avatar_url if avatar_url.present? && !Rails.env.test?
user.apply_oauth(auth)
user.username = auth[:info][:nickname]
end
Expand Down
1 change: 0 additions & 1 deletion config/environments/development.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@

config.action_controller.perform_caching = false
config.action_dispatch.best_standards_support = :builtin
config.action_mailer.delivery_method = :letter_opener
config.action_mailer.raise_delivery_errors = false
config.active_support.deprecation = :log
config.assets.compile = true
Expand Down