Fix team invitation 500s - WIP-331 #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| get :show, id: team.id | ||
| expect(response).to render_template("invitations/show") |
There was a problem hiding this comment.
Can you test for the instance variables if they are correctly assigned too ?
|
I'll add the expectations for controller instance vars real quick |
|
Controller specs updated with checks for instance var, commit squashed. Should be good to go |
| =link_to('Stay with this team', accept_team_path(@team, :r => params[:r]), :class => 'button stay') | ||
| -else | ||
| =link_to('Join this team', accept_team_path(@team, :r => params[:r]), :class => 'join') | ||
| = render partial: "invitations/team_members", locals: {team: @team } |
There was a problem hiding this comment.
Could you use the new syntax
= render 'invitations/team_members' , team: @team
There was a problem hiding this comment.
It's not important enough to warrant waiting. There's a lot of legacy syntax that we'll get to eventually.
|
LGTM! |
just3ws
added a commit
that referenced
this pull request
Aug 14, 2014
Fix team invitation 500s - WIP-331
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work for: https://assembly.com/coderwall/wips/331