Skip to content

Fix #288 - add provider user lookup. #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2014
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions app/controllers/provider_user_lookups_controller.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
require Rails.root.join('app/services/provider_user_lookup_service')

class ProviderUserLookupsController < ApplicationController
def show
service = Services::ProviderUserLookupService.new params[:provider], params[:username]
if user = service.lookup_user
redirect_to badge_path(user.username)
else
redirect_to root_path, flash: { notice: 'User not found' }
end
end
end
26 changes: 26 additions & 0 deletions app/services/provider_user_lookup_service.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
module Services
class ProviderUserLookupService
def initialize(provider, username)
@provider = provider
@username = username
end

def lookup_user
if valid_provider? && valid_username?
User.where(@provider.to_sym => @username).first
else
nil
end
end

private

def valid_provider?
@provider.present? && [:twitter, :github, :linkedin].include?(@provider.to_sym)
end

def valid_username?
@username.present?
end
end
end
2 changes: 2 additions & 0 deletions config/routes.rb
Original file line number Diff line number Diff line change
Expand Up @@ -454,6 +454,8 @@

get '/roll-the-dice' => 'users#randomize', as: :random_wall

get '/providers/:provider/:username' => 'provider_user_lookups#show'


constraints ->(params, _) { params[:username] != 'admin' } do
get '/:username' => 'users#show', as: :badge
Expand Down
34 changes: 34 additions & 0 deletions spec/controllers/provider_user_lookups_controller_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
require 'spec_helper'

RSpec.describe ProviderUserLookupsController, :type => :controller do
let(:twitter_username) { 'birdy' }
let(:github_username) { 'birdy' }
let(:linked_in_username) { 'birdy' }
let(:attrs) do
{
twitter: twitter_username,
github: github_username,
linkedin: linked_in_username
}
end
let!(:user) {
Fabricate.create(:user, attrs)
}

describe 'GET /providers/:provider/:username' do
describe 'known user' do
it 'redirects to the current user for twitter' do
get :show, provider: 'twitter', username: twitter_username
expect(response).to redirect_to(badge_path(user.username))
end
end

describe 'unknown user' do
it 'redirects to the current user for twitter' do
get :show, provider: 'twitter', username: 'unknown'
expect(response).to redirect_to(root_path)
expect(flash[:notice]).to eql('User not found')
end
end
end
end
38 changes: 38 additions & 0 deletions spec/services/provider_user_lookup_service_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
require 'spec_helper'

RSpec.describe Services::ProviderUserLookupService do
let(:twitter_username) { 'birdy' }
let!(:user) {
Fabricate.create(:user, twitter: twitter_username)
}

describe '#lookup_user' do
let(:provider) { 'twitter' }
let(:service) { Services::ProviderUserLookupService.new(provider, username) }

describe 'unknown provider' do
let(:provider) { 'unknown' }
let(:username) { 'unknown' }

it 'returns nil' do
expect(service.lookup_user).to be_nil
end
end

describe 'unknown user' do
let(:username) { 'unknown' }

it 'returns nil' do
expect(service.lookup_user).to be_nil
end
end

describe 'known provider and user' do
let(:username) { twitter_username }

it 'returns the user' do
expect(service.lookup_user).to eql(user)
end
end
end
end