Bounty 389 undefined method banner #218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just3ws
added a commit
that referenced
this pull request
Oct 9, 2014
…nner Bounty 389 undefined method banner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: https://assembly.com/coderwall/bounties/389#
Description: Some users a getting "undefined method banner for nil:NilClass" errors
Cause: when a use is not logged in,
current_userreturns nil, thus causing theNoMethodErrorwhenuser.bannergets called from withinlocation_image_url.Fix: removed the else block, forcing to return nil when other conditions are not satisfied. Returning nil is safe, because the calling
image_pathreturns '/assets' when a nil argument is passed.